Remove array support from gl.Ptr #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves go-gl/gl/issues#2 in part. We also need to regenerate the bindings.
| @@ -13,7 +13,7 @@ import ( | |||
| "unsafe" | |||
| ) | |||
|
|
|||
| // Ptr takes a pointer, slice, or array and returns its GL-compatible address. | |||
| // Ptr takes a pointer or slice and returns its GL-compatible address. | |||
There was a problem hiding this comment.
Can we elaborate on "pointer", pointer to what is okay? Pointer to slice? Pointer to array? Pointer to first element of slice? Pointer to first element of array?
As far as I can tell, only pointers to first elements of slices/arrays are allowed. If so, that should be clearly documented here.
|
LGTM.
Yep, that's task 2 of #52. |
| @@ -34,8 +35,6 @@ func Ptr(data interface{}) unsafe.Pointer { | |||
| addr = unsafe.Pointer(v.Pointer()) | |||
| case reflect.Slice: | |||
| addr = unsafe.Pointer(v.Index(0).UnsafeAddr()) | |||
| case reflect.Array: | |||
| addr = unsafe.Pointer(v.UnsafeAddr()) | |||
| default: | |||
| panic(fmt.Sprintf("Unsupported type %s; must be a pointer, slice, or array", v.Type())) | |||
There was a problem hiding this comment.
Need to also remove "or array" here. I will do that in a PR soon.
Edit: Fixed in #72.
dmitshur
added a commit
that referenced
this pull request
Mar 6, 2016
Currently, gl.Ptr will simply not set value of adds when provided with a pointer to a type that is not supported. That means it returns null pointer, which is likely going to cause issues for user of gl.Ptr. Instead of silently ignoring this, panic with a helpful error message. Also follow up to #55 and remove mention of arrays, they are not supported. Fix for go-gl/gl#32.
dmitshur
added a commit
that referenced
this pull request
Mar 6, 2016
Currently, gl.Ptr will simply not set value of adds when provided with a pointer to a type that is not supported. That means it returns null pointer, which is likely going to cause issues for user of gl.Ptr. Instead of silently ignoring this, panic with a helpful error message. Also follow up to #55 and remove mention of arrays, they are not supported. Fix for go-gl/gl#32.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves (partially) go-gl/gl#2. We also need to regenerate the bindings.