Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install gentool with separated tag #1127

Merged
merged 5 commits into from
Apr 11, 2024
Merged

fix: install gentool with separated tag #1127

merged 5 commits into from
Apr 11, 2024

Conversation

tr1v3r
Copy link
Member

@tr1v3r tr1v3r commented Apr 11, 2024

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

fix #1125

according to https://golang.org/ref/mod#vcs-version

If a module is defined in a subdirectory within the repository, that is, the module subdirectory portion of the module path is not empty, then each tag name must be prefixed with the module subdirectory, followed by a slash. For example, the module golang.org/x/tools/gopls is defined in the gopls subdirectory of the repository with root path golang.org/x/tools. The version v0.4.0 of that module must have the tag named gopls/v0.4.0 in that repository.

User Case Description

@tr1v3r tr1v3r changed the title fix: gentool install error fix: install gentool with separated tag Apr 11, 2024
@tr1v3r tr1v3r merged commit 536bc26 into master Apr 11, 2024
14 checks passed
@tr1v3r tr1v3r deleted the feature/gentool branch April 11, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gentools install broke yesterday - go install gorm.io/gen/tools/gentool@latest fails
1 participant