Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align precision #496

Merged
merged 8 commits into from
Jul 16, 2020
Merged

Align precision #496

merged 8 commits into from
Jul 16, 2020

Conversation

Felixoid
Copy link
Collaborator

@Felixoid Felixoid commented Jul 14, 2020 •
edited

In the case of different metrics steps and lengths carbonapi throws panic.

  • AlignSeries is moved to expr/helper/align.go.
  • FIX: AlignSeries used to generate zeros instead of NaNs, it's NaNs now.
  • Implement MetricData.AggregateFunction that sets and returns an aggregate function for the metric.
  • Implement ScaleToCommonStep function: is metrics in series slice have different steps, it calculates LCM(steps) and aggregates data points to a common step.
  • Use the ScaleToCommonStep function by default, add configuration parameter upstreams.ScaleToCommonStep.
  • FIX: asPercent didn't perform AlignSeries to the series list.

@Felixoid Felixoid marked this pull request as ready for review July 16, 2020 18:57
@Civil Civil self-requested a review July 16, 2020 19:08
@Civil Civil merged commit 8b71194 into go-graphite:main Jul 16, 2020
This was referenced Jul 17, 2020
Closed
Closed
@Felixoid Felixoid mentioned this pull request Jul 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Civil Civil Civil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Felixoid @Civil