Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move precision alignment from per-target zipper to per-request FetchAndEvalExp #501

Merged
merged 5 commits into from Jul 22, 2020
Merged

Move precision alignment from per-target zipper to per-request FetchAndEvalExp #501

merged 5 commits into from Jul 22, 2020

Conversation

Felixoid
Copy link
Collaborator

@Felixoid Felixoid commented Jul 20, 2020 •
edited

It fixes an issue from #496.

With per-target strategy, it doesn't align StepTime always when it's needed. And sometimes the other way around, it aligns unnecessary values.

Changes here:

  • Implement MetricData.Copy function
  • Move ScaleToCommonStep logic from zipper to expr.FetchAndEvalExp
  • Optimize GetCommonStep function
  • Simplify powSeriesLists and make(map) in weightedAverage for DeepSource

Felixoid
Felixoid commented Jul 20, 2020
View reviewed changes
expr/helper/align.go Outdated Show resolved Hide resolved
Civil
Civil previously approved these changes Jul 21, 2020
View reviewed changes
@Civil Civil self-requested a review July 21, 2020 15:51
@Civil Civil merged commit b8affd5 into go-graphite:main Jul 22, 2020
@Felixoid Felixoid mentioned this pull request Aug 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Civil Civil Civil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Felixoid @Civil