Merge pull request #495 from go-graphite/emadolsky/reduce-useless-logs

Reduce useless logs

carbonserver/render.go

@@ -203,7 +203,7 @@ func (listener *CarbonserverListener) renderHandler(wr http.ResponseWriter, req
 		zap.Strings("targets", tgs),
 	)
 
-	logger := TraceContextToZap(ctx, listener.accessLogger.With(
+	logger := TraceContextToZap(ctx, listener.logger.With(
 		zap.String("handler", "render"),
 		zap.String("url", req.URL.RequestURI()),
 		zap.String("peer", req.RemoteAddr),

persister/whisper.go

@@ -1,6 +1,7 @@
 package persister
 
 import (
+	"errors"
 	"fmt"
 	"io/fs"
 	"log"
@@ -22,6 +23,8 @@ import (
 )
 
 const storeMutexCount = 32768
+const maxPathLength = 4095
+const maxFilenameLength = 255
 
 type StoreFunc func(metric string)
 
@@ -255,6 +258,25 @@ func (p *Whisper) store(metric string) {
 		path = filepath.Join(p.rootPath, strings.ReplaceAll(metric, ".", "/")+".wsp")
 	}
 
+	if len(path) > maxPathLength {
+		p.logger.Debug("metric name exceeds limit",
+			zap.String("path", path),
+			zap.Error(errors.New("path too long")))
+		p.popConfirm(metric)
+		return
+	}
+	filenames := strings.Split(path, "/")
+	for _, filename := range filenames {
+		if len(filename) > maxFilenameLength {
+			p.logger.Debug("metric name exceeds limit",
+				zap.String("path", path),
+				zap.String("filename", filename),
+				zap.Error(errors.New("filename too long")))
+			p.popConfirm(metric)
+			return
+		}
+	}
+
 	var newFile bool
 	w, err := whisper.OpenWithOptions(path, &whisper.Options{
 		FLock:      p.flock,

receiver/tcp/tcp.go

@@ -229,7 +229,7 @@ func (rcv *TCP) HandleConnection(conn net.Conn) {
 			name, value, timestamp, err := parse.PlainLine(line)
 			if err != nil {
 				atomic.AddUint32(&rcv.errors, 1)
-				rcv.logger.Info("parse failed",
+				rcv.logger.Debug("parse failed",
 					zap.Error(err),
 					zap.String("peer", conn.RemoteAddr().String()),
 				)

receiver/udp/udp.go

@@ -131,7 +131,7 @@ func (rcv *UDP) receiveWorker(exit chan bool) {
 				name, value, timestamp, err := parse.PlainLine(line)
 				if err != nil {
 					atomic.AddUint32(&rcv.errors, 1)
-					rcv.logger.Info("parse failed",
+					rcv.logger.Debug("parse failed",
 						zap.Error(err),
 						zap.String("peer", peer.String()),
 					)