fix(carbonserver): find - cache http404 responses to prevent redundan…

…t lookups; this also makes logic similar to renderHandler where 404s are cached
go-graphite · Feb 11, 2023 · c754d58 · c754d58
1 parent 0fb928d
commit c754d58
Showing 1 changed file with 0 additions and 10 deletions.
diff --git a/carbonserver/find.go b/carbonserver/find.go
@@ -274,12 +274,7 @@ func (listener *CarbonserverListener) findMetrics(ctx context.Context, logger *z
 			return nil, err
 		}
 
-		if len(multiResponse.Metrics) == 0 {
-			return nil, errorNotFound{}
-		}
-
 		return &result, err
-
 	case protoV2Format:
 		result.contentType = httpHeaders.ContentTypeProtobuf
 		var err error
@@ -299,12 +294,7 @@ func (listener *CarbonserverListener) findMetrics(ctx context.Context, logger *z
 			return nil, err
 		}
 
-		if len(response.Matches) == 0 {
-			return nil, errorNotFound{}
-		}
-
 		return &result, err
-
 	case pickleFormat:
 		// [{'metric_path': 'metric', 'intervals': [(x,y)], 'isLeaf': True},]
 		var metrics []map[string]interface{}