Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply common go linters #365

Closed
deniszh opened this issue Jul 28, 2020 · 4 comments
Closed

Apply common go linters #365

deniszh opened this issue Jul 28, 2020 · 4 comments
Assignees
@deniszh
Labels
enhancement

Comments

@deniszh
Copy link
Member

deniszh commented Jul 28, 2020

It's good to have go fmt, go mod tidy etc. to be applied / tested on every PR.
@deniszh deniszh self-assigned this Jul 28, 2020
@dgryski
Copy link
Member

dgryski commented Aug 17, 2020 •
edited

Also go vet. I recommend also ineffassign, nilness and of course staticcheck, but getting all these passing will require some code changes.

(While we're listing linters I like: ruleguard and gocritic are also reasonable).

@deniszh
Copy link
Member Author

deniszh commented Aug 17, 2020

Yes, enabling linters is easy, but for changes I need a bit of time. :P

@deniszh
Copy link
Member Author

deniszh commented Aug 17, 2020

And (as I lazy) I'm mostly looking for applying tuned golangci through golangci-lint-action.

@deniszh deniszh mentioned this issue Sep 6, 2020
Merged
@deniszh
Copy link
Member Author

deniszh commented Sep 12, 2020

Implemented in #368

@deniszh deniszh closed this as completed Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deniszh deniszh

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgryski @deniszh