Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing linters #368

Merged
merged 15 commits into from Sep 12, 2020
Merged

Implementing linters #368

merged 15 commits into from Sep 12, 2020

Conversation

deniszh
Copy link
Member

@deniszh deniszh commented Sep 6, 2020

Fixing #365. Becoming quite tedious task, but it was fun.
Enabling gofmt, goimports and gocritic, together with others golang-cilint defaults but disabling errcheck (it's too noisy IMO).
I avoided fixing unused struct and S1012.

@deniszh
Copy link
Member Author

deniszh commented Sep 6, 2020

/cc @dgryski @Civil - could you please take a quick glance, maybe I removed something useful?

@deniszh deniszh merged commit 552b4af into go-graphite:master Sep 12, 2020
@deniszh deniszh deleted the DZ-linterz branch September 12, 2020 09:52
@deniszh deniszh mentioned this pull request Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants