Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Disable logs for 404 errors #563

Closed
akamensky opened this issue Aug 14, 2023 · 0 comments
Closed

[FR] Disable logs for 404 errors #563

akamensky opened this issue Aug 14, 2023 · 0 comments

Comments

@akamensky
Copy link

akamensky commented Aug 14, 2023

Is your feature request related to a problem? Please describe.
We use a setup with multiple go-carbon servers where metrics are distributed across using carbon-relay-ng. Which means a metric is present on 1 out of all go-carbon instances. Ingest side is carbon-relay-ng -> (hash-ring) go-carbon, the query side is Grafana -> carbonapi -> (all) go-carbon.

The setup itself works fine, however we get a non-stop spam in the logs with 404 on all nodes. Which is caused by the setup itself. Changing empty-result-ok = true reduces the amount of entries, but also significantly increases query execution time.

Describe the solution you'd like
A simple switch to completely disable logs for 404 error, as those are part of the setup. The default may be to keep writing the logs (so the default behavior does not change).

Additional context
Having a large volume (1000s per minute) of unnecessary logs impedes any other troubleshooting efforts and adds strain on the disk flushing the logs. Also we have to have rather aggressive log rotation policy just to make sure it does not consume unnecessary disk space.

@deniszh deniszh closed this as completed in 1b70cc1 Sep 4, 2023
deniszh added a commit that referenced this issue Sep 4, 2023
Optionally disable 404 error logging (fix #563)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant