trie/bug fixes and finally adds some simple fuzzing logics #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would come with a slightly higher memory overhead for parsing queries.
…uzzing! Fuzzing is nice, uncovered a few more bugs in querying and indexing, some of them is kinda pleasant/revealing to solve. Bellow a simple summaries: * fix endless loop caused by bad query range [0xff-0xff] (a very nice one!) * fix panics caused by evil filename like "..wsp" (less likely to run into on production) * fix max depth logic handling for tree traversal * do not count .wsp in depth * some other more panic fixes
bom-d-van
force-pushed
the
trie/bug-fixes
branch
from
49cb13a
to
fd69165
Compare
deniszh
approved these changes
Oct 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trie: support non-ascii text in metric names and queries [BUG] find failed, can't expand globs #379
This would come with a slightly higher memory overhead for parsing queries.
trie: add some simple fuzzing codes and a few bug fixes revealed by fuzzing!
Fuzzing is nice, uncovered a few more bugs in querying and indexing, some of them is
kinda pleasant/revealing to solve. Bellow a simple summaries: