trie/realtime: set wspConfigRetriever when realtime index is enabled #395 #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniszh
approved these changes
Jan 20, 2021
… after disk scan #395 New unflushed metrics might still be unreachable due to restart though. But it is a different case that happens less frequently and could be addressed in a different commit.
|
Looks like it's fixing #395. Will merge. |
deniszh
approved these changes
Jan 24, 2021
|
Yep, looks so. The deepsource errors aren't actually introduced by this commit and seems to be overlapping with golangci lint but not using the lint ignore/skip comments, so I decided not to address them here. Thanks @deniszh for following it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.