Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fix #406

Merged
merged 4 commits into from Mar 5, 2021
Merged

Tests fix #406

merged 4 commits into from Mar 5, 2021

Conversation

deniszh
Copy link
Member

@deniszh deniszh commented Mar 5, 2021

  • pining ubuntu
  • removing go 1.13

bom-d-van
bom-d-van reviewed Mar 5, 2021
View reviewed changes
carbonserver/carbonserver.go
@@ -837,7 +837,7 @@ func (listener *CarbonserverListener) updateFileList(dir string, cacheMetricName

var freeSpace uint64
// diskspace can be negative and Bavail is therefore int64
if stat.Bavail >= 0 { // nolint:staticcheck skipcq: SCC-SA4003
if stat.Bavail >= 0 { // nolint:staticcheck // skipcq: SCC-SA4003
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not me, but golangci-lint 1.38
But still dunno why "TestThrottleChan" failing, it's working on my laptop :D

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test seems to be a bit unstable. Sometimes it passed, sometimes it failed.
I think we can try modify the 0.95 to 0.9.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or I could re-phase it as the current newThrottleTicker can't meet the [0.95, 1.05] range 100% of the time. :P

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, for me it's failing 100% on GHA and passing 100% on my laptop. Trying 90%-110% range now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, working now, merging

@deniszh deniszh merged commit a02fb72 into go-graphite:master Mar 5, 2021
@deniszh deniszh deleted the DZ-tests-fix branch March 5, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bom-d-van bom-d-van bom-d-van left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deniszh @bom-d-van