Makefile: revert .SHELLFLAGS changes #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are having errors running `make clean && make` due to the flags on linux, not sure the actual cause, but by removing it, it works both on linux and osx: ``` $ make clean && make bash: - : invalid option bash: - : invalid option rm -f go-carbon build/* *deb *rpm bash: - : invalid option make: *** [clean] Error 1 ```
|
Probably related to bash or make versions. Nvm, it's only failsafe precautions. Maybe we should also remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are having errors running
make clean && makedue to the flags on linux, not sure the actual cause,but by removing it, it works both on linux and osx: