Add stats for find and render requests #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eshUsage execution find_hit metrics is sent and flushed
bom-d-van
reviewed
Jul 20, 2022
bom-d-van
reviewed
Jul 20, 2022
bom-d-van
reviewed
Jul 20, 2022
…and write it to Trie index node. We flush metrics periodicly in refreshUsage function
auguzun
changed the title
bom-d-van
reviewed
Jul 25, 2022
carbonserver/render.go
Outdated
| @@ -5,6 +5,9 @@ import ( | |||
| "context" | |||
| "encoding/json" | |||
| "fmt" | |||
|
|
|||
| "github.com/go-graphite/go-whisper" | |||
There was a problem hiding this comment.
nit-picking: probably better move it down bellow the std libraries.
bom-d-van
reviewed
Jul 25, 2022
carbonserver/trie.go
Outdated
| atomic.AddInt64(&meta.readHits, 1) | ||
| } | ||
| } | ||
| func (tn *trieNode) incrementFindBytesMetric(bytesNumber int64) { |
There was a problem hiding this comment.
nit-picking: incrementRenderBytesMetric might be better as only /render/ api call return metric data.
bom-d-van
approved these changes
Jul 25, 2022
bom-d-van
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now each /find produces read_hits metrics and each /render request produce read_hits, read_bytes. During refreshUsage execution these metrics are sent and flushed.