gRPC interceptors #483
Merged
gRPC interceptors #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| bucket := listener.bucketRequestTimes(t) | ||
| if bucket >= listener.buckets { | ||
| listener.logger.Info("slow request", | ||
| zap.String("url", req.URL.RequestURI()), |
Check failure
Code scanning / CodeQL
Log entries created from user input
emadolsky
force-pushed
the
emadolsky/grpc-interceptors
branch
from
97b6a90
to
5887d8c
Compare
deniszh
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP Middlewares for observability and ratelimiting were not implemented for go-carbon gRPC service. This PR adds those functionality alongside small mandatory refactors in order to have less code copies.
In order to implement middlewares, gRPC interceptors are used, and as currently only Render RPC is implemented which is a stream rpc, stream server interceptors are defined and used. For following RPCs (i.e. Find, Info, etc.) we should have unary stream interceptors as well. Which wouldn't be much different with the current implementations.
Three interceptors are created:
httputil.TimeHandlerfor gRPC stream server.TraceHandler. Tracing is not yet implemented for gRPC endpoints.CarbonserverListener.rateLimitRequestfor gRPC stream server. Some refactor is done here.A few parts of the middleware logic are still absent for gRPC: