Add gRPC initial win size of 4MB for less latency #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emadolsky
force-pushed
the
emadolsky/grpc-init-win-size
branch
from
37e23b3
to
8e59456
Compare
azhiltsov
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior of go-grpc is to use BDP and update the window accordingly. The default initial window in this mode is 64KB.
However, 64KB is way smaller than our desired window size and this probably causes more time needed for streams to reach the desired size. So, we expect to see faster responses for our big messages (majorly renders).
We have seen that the streaming phase of gRPC render requests are slower than their counterpart in HTTP, which lead to this tuning.
This PR proposes a big initial window (4MB) to reduce the latency observed while using gRPC comparing to HTTP.