Use find cache for glob expansion in grpc render #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason is that caching render responses in streaming render doesn't make much sense. Also, it reduces performance cause the results get cached when the streaming finishes. All this, seems unnecessary if we could cache glob expansion because most of the times that is what makes requests long (from the trace observation).
azhiltsov
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason is that caching render responses in streaming render doesn't make much sense. Also, it reduces performance cause the results get cached when the streaming finishes. All this, seems unnecessary if we could cache glob expansion because most of the times that is what makes requests long (from the trace observation).