Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(carbonserver): find http/grpc - fix metrics_found metric #521

Merged
merged 1 commit into from
Feb 7, 2023
Merged

fix(carbonserver): find http/grpc - fix metrics_found metric #521

merged 1 commit into from
Feb 7, 2023

Conversation

timtofan
Copy link
Contributor

@timtofan timtofan commented Feb 7, 2023

No description provided.

@timtofan timtofan force-pushed the atimofieiev/noop-cleanup branch 2 times, most recently from 21d4beb to 000ca8d Compare February 7, 2023 14:38
@timtofan timtofan changed the title fix(carbonserver): findMetrics - fix metrics_found metric fix(carbonserver): find http/grpc - fix metrics_found metric Feb 7, 2023
emadolsky
emadolsky approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@emadolsky emadolsky left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. But just as an opinion, I think we might be able to call listener.populateMetricsFoundStat even when there is a loop which does something else as well. It's cleaner but might cause less performance but I don't think that's much. So your call.

@timtofan
Copy link
Contributor Author

timtofan commented Feb 7, 2023

Approved. But just as an opinion, I think we might be able to call listener.populateMetricsFoundStat even when there is a loop which does something else as well. It's cleaner but might cause less performance but I don't think that's much. So your call.

yes I was thinking about it, guess it shouldn't really affect performance, lemme update

@timtofan
Copy link
Contributor Author

timtofan commented Feb 7, 2023

@emadolsky updated

emadolsky
emadolsky approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@emadolsky emadolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks.

@timtofan timtofan merged commit 01a4953 into master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emadolsky emadolsky emadolsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timtofan @emadolsky