Limit streaming channel size dynamically for gRPC render #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azhiltsov
reviewed
Feb 10, 2023
emadolsky
force-pushed
the
emadolsky/streaming-chan-size-limit
branch
from
e6fb10c
to
925f190
Compare
grzkv
approved these changes
Feb 10, 2023
azhiltsov
approved these changes
Feb 10, 2023
A number of files in the expanded globs is smaller than that maximum, it makes sense to initiate chan with that size instead of maximum.
emadolsky
force-pushed
the
emadolsky/streaming-chan-size-limit
branch
from
925f190
to
eda9bf6
Compare
emadolsky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if number of files in the expanded globs is smaller than that maximum, it makes sense to initiate chan with that size instead of maximum.