groot/rdict: leverage rbytes.{Unm,M}arshaler implementation in Bind #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbinet
force-pushed
the
issue-880
branch
2 times, most recently
from
2fc26da
to
ca6099b
Compare
Codecov Report
@@ Coverage Diff @@
## main #881 +/- ##
=======================================
Coverage 73.12% 73.12%
=======================================
Files 392 392
Lines 45608 45630 +22
=======================================
+ Hits 33349 33367 +18
- Misses 10018 10021 +3
- Partials 2241 2242 +1
Continue to review full report at Codecov.
|
sbinet
force-pushed
the
issue-880
branch
3 times, most recently
from
dc8a318
to
8b7aabd
Compare
This CL adds a temporary mitigation of go-hep#880. It tries to detect whether a given receiver for binding implements rbytes.Unmarshaler and use it instead of generating rstreamers. rstreamers may not properly work in the case where fields of a struct aren't exported. Fixes go-hep#880.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #880.