This repository has been archived by the owner on May 11, 2020. It is now read-only.
4/4 - Implement native compilation - plug backend + more tests. #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 22, 2019 16:01
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
+ Coverage 64.58% 65.51% +0.93%
==========================================
Files 40 41 +1
Lines 3871 3883 +12
==========================================
+ Hits 2500 2544 +44
+ Misses 1109 1072 -37
- Partials 262 267 +5
Continue to review full report at Codecov.
|
|
I've merged master in, this should be good for review :) |
sbinet
reviewed
Apr 3, 2019
exec/native_compile_test.go
Outdated
| // setup mocks. | ||
| nc.Scanner.(*mockSequenceScanner).emit = []compile.CompilationCandidate{ | ||
| // Sequence with single integer op - should not compiled. | ||
| compile.CompilationCandidate{Start: 0, End: 7, EndInstruction: 3, Metrics: compile.Metrics{IntegerOps: 1}}, |
There was a problem hiding this comment.
looking at the history of the changes, it doesn't seem to me EndInstruction's value was changed here, nor below.
shouldn't they be (resp.) 4 and 10 ?
There was a problem hiding this comment.
Fixed.
Note: Start/EndInstruction is not part of the code under test, this test just tests tryNativeCompile(), and mocks everything else.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review/merge the other PRs in this series first - this builds on those commits.
This is the final PR that enables a minimal (but working) amd64 native backend.
Future PRs will be small additions to support more and more opcodes.