This repository has been archived by the owner on May 11, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 150
Implement comparison Ops, fix bug with branch table target tracking, add benchmark. #119
Merged
sbinet
merged 20 commits into
go-interpreter:master
from
twitchyliquid64:ZOMG_SAH_MANY_OPS
Apr 5, 2019
Merged
Implement comparison Ops, fix bug with branch table target tracking, add benchmark. #119
sbinet
merged 20 commits into
go-interpreter:master
from
twitchyliquid64:ZOMG_SAH_MANY_OPS
Apr 5, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
==========================================
+ Coverage 65.61% 65.98% +0.37%
==========================================
Files 41 41
Lines 3949 4066 +117
==========================================
+ Hits 2591 2683 +92
- Misses 1091 1116 +25
Partials 267 267
Continue to review full report at Codecov.
|
sbinet
reviewed
Apr 5, 2019
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my i7 2nd gen:
So currently 3x, but heaps of room for improvement (I think I can cut emitted assembly by 80%, and theres still heaps of opcodes we dont yet support). I'm expecting we should be able to hit 10-20x here.