This repository has been archived by the owner on May 11, 2020. It is now read-only.
wasm: fix types decoding #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laizy
commented
Aug 2, 2019
| ValueTypeI32 ValueType = 0x7f | ||
| ValueTypeI64 ValueType = 0x7e | ||
| ValueTypeF32 ValueType = 0x7d | ||
| ValueTypeF64 ValueType = 0x7c |
There was a problem hiding this comment.
These constants are obtained from the specification: https://webassembly.github.io/spec/core/binary/types.html#binary-valtype
sbinet
reviewed
Aug 2, 2019
wasm/read.go
Outdated
| @@ -35,6 +35,17 @@ func readBytes(r io.Reader, n int) ([]byte, error) { | |||
| return nil, io.ErrUnexpectedEOF | |||
| } | |||
|
|
|||
| func WriteByte(w io.Writer, b byte) error { | |||
There was a problem hiding this comment.
perhaps put it in a new wasm/write.go file?
also, perhaps:
Suggested change
| func WriteByte(w io.Writer, b byte) error { | |
| func writeByte(w io.Writer, b byte) error { |
There was a problem hiding this comment.
The ReadByte method is used in disasm package. For the sake of symmetry, I exposed it too. and maybe it will be used in later fix.
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
==========================================
- Coverage 69.61% 69.54% -0.07%
==========================================
Files 43 43
Lines 4959 4974 +15
==========================================
+ Hits 3452 3459 +7
- Misses 1222 1226 +4
- Partials 285 289 +4
Continue to review full report at Codecov.
|
sbinet
approved these changes
Aug 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.