This repository has been archived by the owner on May 11, 2020. It is now read-only.
Refactor validate module to use spec-defined algorithm #143 #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
=======================================
Coverage 69.54% 69.54%
=======================================
Files 43 43
Lines 5007 5007
=======================================
Hits 3482 3482
Misses 1231 1231
Partials 294 294Continue to review full report at Codecov.
|
sbinet
approved these changes
Sep 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validate module uses a custom validation algorithm that doesnt correctly handle stack-polymorphic opcodes at all. This PR refactors it into the algorithm described in the specification.