Skip to content
This repository has been archived by the owner on May 11, 2020. It is now read-only.

Test suite & fixes for validate package #161

Merged
merged 10 commits into from
Sep 13, 2019
Merged

Test suite & fixes for validate package #161

merged 10 commits into from
Sep 13, 2019

Conversation

twitchyliquid64
Copy link
Contributor

I've started working through the official test suite and representing the tests specified in there as tests on the validate module.

As I go, I'm fixing any issues I find.

@codecov-io
Copy link

codecov-io commented Sep 4, 2019

Codecov Report

Merging #161 into master will decrease coverage by 0.1%.
The diff coverage is 66.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   69.72%   69.61%   -0.11%     
==========================================
  Files          43       48       +5     
  Lines        5010     5466     +456     
==========================================
+ Hits         3493     3805     +312     
- Misses       1221     1317      +96     
- Partials      296      344      +48
Impacted Files Coverage Δ
validate/error.go 0% <0%> (ø)
validate/vm.go 84.15% <71.42%> (ø)
validate/validate.go 68.86% <90%> (ø)
validate/log.go 66.66% <0%> (ø)
validate/operand.go 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbbdf08...5ef5e36. Read the comment docs.

@twitchyliquid64
Copy link
Contributor Author

Okay, I think thats a good amount of tests for one PR. Feel free to review at your leisure (no rush 😄 ).

Copy link
Contributor

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

only a couple of nit-picks.
thanks!

validate/validate_test.go Show resolved Hide resolved
validate/validate_test.go Outdated Show resolved Hide resolved
validate/validate_test.go Outdated Show resolved Hide resolved
validate/validate_test.go Outdated Show resolved Hide resolved
validate/validate_test.go Outdated Show resolved Hide resolved
validate/validate_test.go Outdated Show resolved Hide resolved
validate/validate_test.go Outdated Show resolved Hide resolved
@twitchyliquid64
Copy link
Contributor Author

@sbinet this is ready, but the two new PR checks are failing ... what are they? can we skip them?

@sbinet
Copy link
Contributor

sbinet commented Sep 13, 2019

yeah, codecov is being a bit too stringent (and speaks up when the code coverage drops by some tiny margin.)
not sure how to change that...

@sbinet sbinet merged commit 7bc5f1f into go-interpreter:master Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants