-
Notifications
You must be signed in to change notification settings - Fork 150
Test suite & fixes for validate package #161
Conversation
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
==========================================
- Coverage 69.72% 69.61% -0.11%
==========================================
Files 43 48 +5
Lines 5010 5466 +456
==========================================
+ Hits 3493 3805 +312
- Misses 1221 1317 +96
- Partials 296 344 +48
Continue to review full report at Codecov.
|
Okay, I think thats a good amount of tests for one PR. Feel free to review at your leisure (no rush 😄 ). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
only a couple of nit-picks.
thanks!
@sbinet this is ready, but the two new PR checks are failing ... what are they? can we skip them? |
yeah, codecov is being a bit too stringent (and speaks up when the code coverage drops by some tiny margin.) |
I've started working through the official test suite and representing the tests specified in there as tests on the validate module.
As I go, I'm fixing any issues I find.