This repository has been archived by the owner on May 11, 2020. It is now read-only.
leb128:add ReadVarUint64 function and fix overflow corner case #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
==========================================
+ Coverage 69.73% 69.75% +0.01%
==========================================
Files 48 48
Lines 5489 5491 +2
==========================================
+ Hits 3828 3830 +2
Misses 1318 1318
Partials 343 343
Continue to review full report at Codecov.
|
twitchyliquid64
approved these changes
Oct 30, 2019
wasm/leb128/read_test.go
Outdated
| @@ -217,6 +234,8 @@ func readVarUintRecur(r io.Reader, n uint) (uint64, error) { | |||
| } | |||
| } | |||
|
|
|||
| // a less efficent recurrsive version but matches the spec defined in https://webassembly.github.io/spec/core/binary/values.html#integers | |||
There was a problem hiding this comment.
s/recurrsive/recursive
laizy
commented
Oct 30, 2019
laizy
commented
Oct 30, 2019
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #175