jwe: limit maximum output from decompressing #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcpherrinm
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
I have reviewed this and I think it's good:
One thing I did consider is that if int64(len(input)) is large, then 10x it could overflow. But having an input that large isn't possible, as it wouldn't fit on system memory in any system. We'd cap at 250_000 in that case anyways, as it would be larger than a negative overflowed value.
jsha
added a commit
that referenced
this pull request
Mar 7, 2024
jsha
added a commit
that referenced
this pull request
Mar 7, 2024
Backport from #106. Note that there was a merge conflict on the CHANGELOG and I decided to just accept all the v4 entries. It's okay for the v3 branch's CHANGELOG to also talk about v4 releases. I'll send a separate PR updating the v4 CHANGELOG to include v3.0.3.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.