Enforce minimum length for HMAC keys #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the test cases that were using undersized keys. For `hmacSignedToken`, since it had to be regenerated anyhow, move generation into an `init()` function. For the example tests, replace panics with print and exit. This allows multiple tests to fail during a given run, since example tests do not catch panics in the same way ordinary tests do.
aarongable
approved these changes
Dec 15, 2023
beautifulentropy
approved these changes
Dec 15, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the test cases that were using undersized keys. For
hmacSignedToken, since it had to be regenerated anyhow, move generation into aninit()function.For the example tests, replace panics with print and exit. This allows multiple tests to fail during a given run, since example tests do not catch panics in the same way ordinary tests do.
Fixes #83