Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert over to "official" rabbitmq library #1178

Closed
SteelPhase opened this issue Aug 19, 2021 · 1 comment · Fixed by #1210
Closed

Convert over to "official" rabbitmq library #1178

SteelPhase opened this issue Aug 19, 2021 · 1 comment · Fixed by #1210

Comments

@SteelPhase
Copy link

What would you like?

the RabbitMQ team has pulled in https://github.com/streadway/amqp into https://github.com/rabbitmq/amqp091-go

You can see the conversation here

@sagikazarmark
Copy link
Contributor

sagikazarmark commented Aug 19, 2021

My gut tells me that it should probably be a new transport outside of the core repository, but I'm a bit hesitant to be honest: Go kit is going to face a large refactor once generics is released and I'm not sure starting to decompose the core repository before that is a good idea.

In any case, you can always release a transport with the new library under your name and Go kit can link to it from the README. I'd say that's the best way to start this anyway.

peterbourgon pushed a commit that referenced this issue Jan 7, 2022
Close #1178.

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants