Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make levels API more composable. #157

Merged
merged 1 commit into from Dec 6, 2015
Merged

Make levels API more composable. #157

merged 1 commit into from Dec 6, 2015

Conversation

@ChrisHines
Copy link
Member

@ChrisHines ChrisHines commented Nov 28, 2015

Fixes #131.

@ChrisHines
Copy link
Member Author

@ChrisHines ChrisHines commented Nov 28, 2015

This is a breaking change. I will post it to the mailing list and Slack channel and see if there are any objections before I merge.

@tgulacsi
Copy link

@tgulacsi tgulacsi commented Nov 28, 2015

I like this change, takes the leveled logging back to the group of the other loggers.

ChrisHines added a commit that referenced this pull request Dec 6, 2015
Make levels API more composable.
@ChrisHines ChrisHines merged commit 0733761 into master Dec 6, 2015
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@peterbourgon
Copy link
Member

@peterbourgon peterbourgon commented Dec 8, 2015

May I delete the branch?

@ChrisHines ChrisHines deleted the levels-api branch Dec 8, 2015
@ChrisHines
Copy link
Member Author

@ChrisHines ChrisHines commented Dec 8, 2015

Taken care of.

guycook pushed a commit to codelingo/kit that referenced this pull request Oct 12, 2016
Make levels API more composable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.