-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kitgen implementation #589
Conversation
Every implementation (modulo mock/test impls) already provided this method, and so it makes sense to lift it to the interface definition. Closes go-kit#566.
Dogstatsd doesn't support sending deltas for gauges, so we must maintain the raw gauge value ourselves.
… does. Note there is a breaking API change, as the cloudwatch object now has optional parameters.
…r() did not add any samples.
I'll be proceeding with this, but I wanted to get a little oversight to see if it's in a useful vein, @peterbourgon |
Ah! I missed the notification! This is great. Let me dig in later today and I'll give some more specific comments... |
Yeah, this is badass. Pretty much exactly what I had in mind, modulo the parameterization that you've already acknowledged. I also noticed it panics when I don't name the parameters in my service definition, i.e. type Service interface {
Foo(context.Context, int, int) (int, error) // panic
Bar(ctx context.Context, i, j int) (int, error) // OK
} If you have enough to move forward, great! If not, please let me know how I can help: clarifying, requirements-gathering, etc. |
Hehe, fun!
|
I'm good. Just wanted to make sure I wasn't running down a rathole. :) The edge cases are great. Thanks! |
sd: fix TestDefaultEndpointer flake, hopefully
changed `NewContext -> NewOutgoingContext` and `FromContext -> FromIncomingContext` as described in [metadta](https://github.com/grpc/grpc-go/blob/master/metadata/metadata.go)
Make sure Cloudwatch-metrics only send the *new* counter values.
removed deprecated functions
Okay - there's the rebase 🤞 |
Woohoo! |
I've been trying it out and it works great, thank you @nyarly |
So far what I've got is simple generation based on a basic interface definition.
Not complete: different layout engines.
Specific design decision here was to construct the generated AST and then
format it out, as opposed to using a text/template. There's some things that
are made much easier this way (i.e. the output is more likely to be correct
code), but the generation code is a bit more opaque. In working with this
process I've found a few things that make the process clearer, and I'm looking
to implement those before this is merged. Specifically, I think many of the
repeated structures could be snagged from an example codefile and then
processed into target structures, rather than built out of whole cloth or
partial inline parses.