Skip to content

Commit

Permalink
fix client do method done not use when err not nil (#1948)
Browse files Browse the repository at this point in the history
  • Loading branch information
zhaobingchun committed Apr 25, 2022
1 parent ae230eb commit 4472cdb
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions transport/http/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -289,13 +289,12 @@ func (client *Client) do(req *http.Request) (*http.Response, error) {
if err == nil {
err = client.opts.errorDecoder(req.Context(), resp)
}

if err != nil {
return nil, err
}
if done != nil {
done(req.Context(), selector.DoneInfo{Err: err})
}
if err != nil {
return nil, err
}
return resp, nil
}

Expand Down

0 comments on commit 4472cdb

Please sign in to comment.