Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github action): use golangci-lint to replace the deprecated golint #1175

Merged
merged 10 commits into from
Jul 12, 2021
Merged

ci(github action): use golangci-lint to replace the deprecated golint #1175

merged 10 commits into from
Jul 12, 2021

Conversation

ymh199478
Copy link
Member

@ymh199478 ymh199478 commented Jul 12, 2021

使用 golangci-lint 来替代了 golint 检测,检测忽略了 test 文件,对于 PR 不主动检测旧的代码(非变更代码),目前启用了以下检测插件

  • revive
  • staticcheck
  • govet

提交中包含了以下关联性改动:

  • 对于新CI检测到的问题,本次PR不对问题进行修复,仅使用 todo 标记,标记问题。
  • 提交对于 冗余代码 类型的问题,进行了更正。
  • 根据 golangci-lint-action/issues/23 描述的内容,检测工具任务将会放在独立的 job 中进行。
  • 添加了一个手动触发器用于手动触发 github action 任务

Merge 时请合并提交历史,closed #1173

@ymh199478 ymh199478 changed the title ci: use golangci-lint to replace the deprecated golint ci(github action): use golangci-lint to replace the deprecated golint Jul 12, 2021
Copy link
Member

@Windfarer Windfarer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@tonybase tonybase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonybase tonybase merged commit 4780b6e into go-kratos:main Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Upgrade] golint 静态分析工具已被弃用,需要使用其他分析工具替代
3 participants