Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(middleware/ratelimit): add rate limiter middleware #1271

Merged
merged 22 commits into from Sep 5, 2021

Conversation

kagaya85
Copy link
Member

@kagaya85 kagaya85 commented Jul 28, 2021

Add Limiter middleware

part of #889

PTAL @longXboy @tonybase, Thanks : )

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2021

Codecov Report

Merging #1271 (41a4bee) into main (47f0397) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1271   +/-   ##
=======================================
  Coverage   64.68%   64.68%           
=======================================
  Files          63       63           
  Lines        2917     2917           
=======================================
  Hits         1887     1887           
  Misses        871      871           
  Partials      159      159           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f0397...41a4bee. Read the comment docs.

daemon365
daemon365 previously approved these changes Jul 29, 2021
@longXboy
Copy link
Member

longXboy commented Aug 9, 2021

是不是可以把bbr搞进来了?@kagaya85

@kagaya85
Copy link
Member Author

是不是可以把bbr搞进来了?@kagaya85

我们是在使用的时候让用户再传入对应的limiter实现还是直接内置bbr算法?

@longXboy
Copy link
Member

是不是可以把bbr搞进来了?@kagaya85

我们是在使用的时候让用户再传入对应的limiter实现还是直接内置bbr算法?

默认就bbr吧,也支持手动设置

@kagaya85
Copy link
Member Author

是不是可以把bbr搞进来了?@kagaya85

我们是在使用的时候让用户再传入对应的limiter实现还是直接内置bbr算法?

默认就bbr吧,也支持手动设置

采用默认的方式可能需要产生额外的依赖,我先修改一下看一下

tonybase
tonybase previously approved these changes Aug 13, 2021
@tonybase tonybase added this to the v2.1.0 milestone Sep 5, 2021
middleware/ratelimit/go.mod Outdated Show resolved Hide resolved
middleware/ratelimit/limiter.go Outdated Show resolved Hide resolved
middleware/ratelimit/limiter.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@tonybase tonybase merged commit de55281 into go-kratos:main Sep 5, 2021
@kagaya85 kagaya85 deleted the feat-ratelimit branch September 5, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants