Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config/env): polish watcher #1341

Merged
merged 2 commits into from Aug 16, 2021
Merged

Conversation

xuyang2
Copy link
Contributor

@xuyang2 xuyang2 commented Aug 16, 2021

Should fix #1340

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2021

Codecov Report

Merging #1341 (451bb79) into main (80378ca) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1341      +/-   ##
==========================================
+ Coverage   63.03%   63.27%   +0.24%     
==========================================
  Files          61       61              
  Lines        2824     2821       -3     
==========================================
+ Hits         1780     1785       +5     
+ Misses        896      888       -8     
  Partials      148      148              
Impacted Files Coverage Δ
config/env/watcher.go 100.00% <100.00%> (+61.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80378ca...451bb79. Read the comment docs.

@tonybase tonybase merged commit 3026f94 into go-kratos:main Aug 16, 2021
@shenqidebaozi
Copy link
Sponsor Member

合并到 main 后,golint 出错了,是否可以继续提交一个 pr 来修复它?

@shenqidebaozi
Copy link
Sponsor Member

合并到 main 后,golint 出错了,是否可以继续提交一个 pr 来修复它?

我提了。

zouyx pushed a commit to zouyx/kratos that referenced this pull request Aug 24, 2021
* chore(config/env): polish watcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2/config/env watcher stop 后,next 返回值不确定
4 participants