Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:http server start panic when use Endpoint #1492

Merged
merged 1 commit into from Sep 18, 2021
Merged

Conversation

daemon365
Copy link
Member

Description (what this PR does / why we need it):

Which issue(s) this PR fixes (resolves / be part of):

fixes #

Other special notes for reviewer:

@codecov-commenter
Copy link

Codecov Report

Merging #1492 (70d20a3) into main (55e00ce) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1492      +/-   ##
==========================================
+ Coverage   69.50%   69.51%   +0.01%     
==========================================
  Files          66       66              
  Lines        3033     3028       -5     
==========================================
- Hits         2108     2105       -3     
+ Misses        746      745       -1     
+ Partials      179      178       -1     
Impacted Files Coverage Δ
transport/http/server.go 75.00% <ø> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55e00ce...70d20a3. Read the comment docs.

Copy link
Member

@ymh199478 ymh199478 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@longXboy longXboy merged commit 423b60b into main Sep 18, 2021
@longXboy longXboy deleted the fix/start_panic2 branch September 18, 2021 03:24
@daemon365 daemon365 restored the fix/start_panic2 branch September 18, 2021 03:25
@daemon365 daemon365 deleted the fix/start_panic2 branch September 18, 2021 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants