Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add backupConfigPath method #1511

Merged
merged 2 commits into from Oct 6, 2021
Merged

feat: add backupConfigPath method #1511

merged 2 commits into from Oct 6, 2021

Conversation

ONG-YA
Copy link
Contributor

@ONG-YA ONG-YA commented Sep 24, 2021

Description (what this PR does / why we need it):

Which issue(s) this PR fixes (resolves / be part of):

fixes #

Other special notes for reviewer:

@ONG-YA
Copy link
Contributor Author

ONG-YA commented Sep 24, 2021

#1511

@kagaya85
Copy link
Member

Hi @ONG-YA, Thanks for your contribution, is this PR ready for review?

@kagaya85 kagaya85 linked an issue Sep 24, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2021

Codecov Report

Merging #1511 (cc43605) into main (953deaa) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head cc43605 differs from pull request most recent head 49aa133. Consider uploading reports for the commit 49aa133 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1511      +/-   ##
==========================================
- Coverage   68.63%   68.56%   -0.07%     
==========================================
  Files          67       67              
  Lines        3089     3089              
==========================================
- Hits         2120     2118       -2     
- Misses        789      791       +2     
  Partials      180      180              
Impacted Files Coverage Δ
middleware/auth/jwt/jwt.go 85.71% <ø> (ø)
internal/context/context.go 97.01% <0.00%> (-2.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 953deaa...49aa133. Read the comment docs.

@ONG-YA ONG-YA changed the title add backupConfigPath method feat: add backupConfigPath method Sep 27, 2021
Copy link
Sponsor Member

@shenqidebaozi shenqidebaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonybase tonybase merged commit a996590 into go-kratos:main Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apollo can not set the BackupConfigPath ?
5 participants