Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: completion command in the comment #1680

Merged
merged 1 commit into from Dec 9, 2021
Merged

Conversation

qloog
Copy link
Contributor

@qloog qloog commented Dec 9, 2021

fix cmd in the comment

@codecov-commenter
Copy link

Codecov Report

Merging #1680 (d551aeb) into main (8c9e70b) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1680      +/-   ##
==========================================
- Coverage   81.16%   81.02%   -0.15%     
==========================================
  Files          78       78              
  Lines        3420     3420              
==========================================
- Hits         2776     2771       -5     
- Misses        442      446       +4     
- Partials      202      203       +1     
Impacted Files Coverage Δ
selector/node/ewma/node.go 83.87% <0.00%> (-3.23%) ⬇️
internal/context/context.go 97.01% <0.00%> (-2.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c9e70b...d551aeb. Read the comment docs.

Copy link
Member

@daemon365 daemon365 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Cluas
Copy link
Contributor

Cluas commented Dec 9, 2021

/LGTM

@tonybase tonybase merged commit c9e19f1 into go-kratos:main Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants