transport/http: delay pass context.Context #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1684 +/- ##
==========================================
- Coverage 81.16% 81.16% -0.01%
==========================================
Files 78 78
Lines 3420 3419 -1
==========================================
- Hits 2776 2775 -1
Misses 442 442
Partials 202 202
Continue to review full report at Codecov.
|
Cluas
changed the title
ziguss
reviewed
Dec 12, 2021
Cluas
changed the title
tonybase
previously approved these changes
Dec 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
The current http request ctx does not carry the user construct, so some timeouts and so on will fail.
Which issue(s) this PR fixes (resolves / be part of):
fixes #
#1683
Other special notes for reviewer: