fix(cmd/proto-gen-http): non nil assertion for error #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1700 +/- ##
==========================================
+ Coverage 81.08% 81.11% +0.02%
==========================================
Files 78 78
Lines 3431 3431
==========================================
+ Hits 2782 2783 +1
Misses 445 445
+ Partials 204 203 -1
Continue to review full report at Codecov.
|
daemon365
previously approved these changes
Dec 19, 2021
Cluas
previously approved these changes
Dec 19, 2021
|
貌似一些其他库或者标准库里面都没有对nil 做判断。一般应该都是外面判断之后传进来？ |
标准库errors.Is是有判断nil的 |
shenqidebaozi
changed the title
JerryZhou343
force-pushed
the
nil-judge
branch
from
53778dd
to
0f51900
Compare
Cluas
approved these changes
Dec 20, 2021
daemon365
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复： errors 插件生成的代码中， Isxxx 判断函数未对 入参 err 进行空判断。