Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(registry/consul): fix can not find service in 20s #1728

Merged
merged 3 commits into from
Dec 31, 2021

Conversation

letian0805
Copy link
Contributor

@letian0805 letian0805 commented Dec 29, 2021

Description (what this PR does / why we need it):

Which issue(s) this PR fixes (resolves / be part of):

fixes #1727 problem 1

Other special notes for reviewer:

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021

Codecov Report

Merging #1728 (da6a978) into main (11a6120) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1728      +/-   ##
==========================================
- Coverage   81.17%   81.12%   -0.05%     
==========================================
  Files          78       78              
  Lines        3469     3476       +7     
==========================================
+ Hits         2816     2820       +4     
- Misses        449      450       +1     
- Partials      204      206       +2     
Impacted Files Coverage Δ
transport/http/resolver.go 64.00% <0.00%> (-4.00%) ⬇️
selector/node/ewma/node.go 83.87% <0.00%> (-3.23%) ⬇️
transport/grpc/client.go 95.45% <0.00%> (-0.06%) ⬇️
transport/grpc/server.go 93.33% <0.00%> (+1.25%) ⬆️
transport/http/server.go 77.41% <0.00%> (+2.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11a6120...da6a978. Read the comment docs.

longXboy
longXboy previously approved these changes Dec 30, 2021
@longXboy longXboy merged commit 17201cd into go-kratos:main Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consul服务注册和发现两个问题
5 participants