Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade:upgrade grpc and opentelemetry version #1751

Merged
merged 3 commits into from
Jan 6, 2022

Conversation

daemon365
Copy link
Member

Description (what this PR does / why we need it):

Which issue(s) this PR fixes (resolves / be part of):

fixes #

Other special notes for reviewer:

@codecov-commenter
Copy link

Codecov Report

Merging #1751 (6780cbb) into main (7fe194e) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1751      +/-   ##
==========================================
- Coverage   81.77%   81.75%   -0.03%     
==========================================
  Files          78       78              
  Lines        3474     3474              
==========================================
- Hits         2841     2840       -1     
  Misses        429      429              
- Partials      204      205       +1     
Impacted Files Coverage Δ
transport/grpc/client.go 95.45% <100.00%> (ø)
selector/node/ewma/node.go 83.87% <0.00%> (-3.23%) ⬇️
internal/context/context.go 100.00% <0.00%> (+2.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe194e...6780cbb. Read the comment docs.

Copy link
Member

@tonybase tonybase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonybase tonybase merged commit da70e22 into main Jan 6, 2022
@tonybase tonybase deleted the upgrade_grpc_otel_version branch January 6, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants