Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make logger appliance as logger proxy #1765

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

realityone
Copy link
Contributor

Description (what this PR does / why we need it):

Make global logger appliance as inner logger proxy, ensure logger change will effect to all sub-loggers.

Which issue(s) this PR fixes (resolves / be part of):

fixes #

Other special notes for reviewer:

@codecov-commenter
Copy link

Codecov Report

Merging #1765 (6ae59f8) into main (c6c5e45) will increase coverage by 0.05%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1765      +/-   ##
==========================================
+ Coverage   81.24%   81.30%   +0.05%     
==========================================
  Files          79       79              
  Lines        3525     3525              
==========================================
+ Hits         2864     2866       +2     
+ Misses        457      455       -2     
  Partials      204      204              
Impacted Files Coverage Δ
log/global.go 37.77% <50.00%> (ø)
internal/context/context.go 100.00% <0.00%> (+2.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6c5e45...6ae59f8. Read the comment docs.

@tonybase tonybase merged commit 83fad75 into go-kratos:main Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants