Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consul heartbeat ttl not registered #1781

Merged
merged 3 commits into from
Jan 21, 2022
Merged

fix: consul heartbeat ttl not registered #1781

merged 3 commits into from
Jan 21, 2022

Conversation

longXboy
Copy link
Member

fix: consul heartbeat ttl not registered

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2022

Codecov Report

Merging #1781 (1472c1c) into main (c250958) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 1472c1c differs from pull request most recent head 63e402e. Consider uploading reports for the commit 63e402e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1781      +/-   ##
==========================================
+ Coverage   80.71%   80.74%   +0.02%     
==========================================
  Files          80       80              
  Lines        3557     3557              
==========================================
+ Hits         2871     2872       +1     
  Misses        479      479              
+ Partials      207      206       -1     
Impacted Files Coverage Δ
internal/context/context.go 97.01% <0.00%> (-2.99%) ⬇️
selector/node/ewma/node.go 87.09% <0.00%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c250958...63e402e. Read the comment docs.

Cluas
Cluas previously approved these changes Jan 21, 2022
daemon365
daemon365 previously approved these changes Jan 21, 2022
@longXboy longXboy dismissed stale reviews from daemon365 and Cluas via 63e402e January 21, 2022 07:39
@Casper-Mars Casper-Mars linked an issue Jan 21, 2022 that may be closed by this pull request
@longXboy longXboy merged commit a87abe2 into main Jan 21, 2022
@longXboy longXboy deleted the fix/consul_hearbeat branch January 21, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TTL check is not added when consul starts heartbeat
4 participants