-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(registry/polaris): add registry for Tencent Polaris #1816
Conversation
看了一下Actions的错,Go / build & test是polaris没部署导致测试出错 |
业务上发送了问题,要小修改确认一下 |
请把go lint解决一下,感谢 |
OK,等我回到公司空余时间搞一下,还发现了逻辑错误,搞好我推一下🤔 |
1.fix missing instance id 2.fix lint
看起来lint可以了,测试没过还是因为没有部署注册中心🤔 |
单元测试的话随便mock一下 就可以了 |
我研究一下怎么在docker部署polaris,example今天或者明天能加上 |
焯,一直部署不了 |
用官方的部署要挂载配置文件,搞了一天没搞好,自己封装了一个镜像来测试。 |
Codecov Report
@@ Coverage Diff @@
## main #1816 +/- ##
==========================================
- Coverage 80.80% 80.74% -0.06%
==========================================
Files 80 80
Lines 3558 3558
==========================================
- Hits 2875 2873 -2
- Misses 477 479 +2
Partials 206 206
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
merge main一下 @huyuanxin |
1.add heartbeat report 2.fix conversations
Description (what this PR does / why we need it):
This PR creates a registry for Tencent Polaris
Which issue(s) this PR fixes (resolves / be part of):
fixes no issues
Other special notes for reviewer: