Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(registry/polaris): add registry for Tencent Polaris #1816

Merged
merged 13 commits into from
Feb 21, 2022
Merged

feat(registry/polaris): add registry for Tencent Polaris #1816

merged 13 commits into from
Feb 21, 2022

Conversation

huyuanxin
Copy link
Contributor

@huyuanxin huyuanxin commented Feb 14, 2022

Description (what this PR does / why we need it):

This PR creates a registry for Tencent Polaris

Which issue(s) this PR fixes (resolves / be part of):

fixes no issues

Other special notes for reviewer:

@huyuanxin
Copy link
Contributor Author

看了一下Actions的错,Go / build & test是polaris没部署导致测试出错

@huyuanxin
Copy link
Contributor Author

业务上发送了问题,要小修改确认一下

@longXboy
Copy link
Member

longXboy commented Feb 14, 2022

请把go lint解决一下,感谢

@huyuanxin
Copy link
Contributor Author

OK,等我回到公司空余时间搞一下,还发现了逻辑错误,搞好我推一下🤔

@huyuanxin
Copy link
Contributor Author

huyuanxin commented Feb 15, 2022

看起来lint可以了,测试没过还是因为没有部署注册中心🤔
大意了,没看到怎么cdci部署polaris

@daemon365
Copy link
Member

看起来lint可以了,测试没过还是因为没有部署注册中心🤔 大意了,没看到怎么cdci部署polaris

单元测试的话随便mock一下 就可以了
可以的话 在这https://github.com/go-kratos/kratos/tree/main/examples/registry 加个简单的example 非常感谢

@huyuanxin
Copy link
Contributor Author

看起来lint可以了,测试没过还是因为没有部署注册中心🤔 大意了,没看到怎么cdci部署polaris

单元测试的话随便mock一下 就可以了 可以的话 在这https://github.com/go-kratos/kratos/tree/main/examples/registry 加个简单的example 非常感谢

我研究一下怎么在docker部署polaris,example今天或者明天能加上

@huyuanxin
Copy link
Contributor Author

焯,一直部署不了

@huyuanxin
Copy link
Contributor Author

用官方的部署要挂载配置文件,搞了一天没搞好,自己封装了一个镜像来测试。

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2022

Codecov Report

Merging #1816 (369cccb) into main (9662ef3) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1816      +/-   ##
==========================================
- Coverage   80.80%   80.74%   -0.06%     
==========================================
  Files          80       80              
  Lines        3558     3558              
==========================================
- Hits         2875     2873       -2     
- Misses        477      479       +2     
  Partials      206      206              
Impacted Files Coverage Δ
internal/context/context.go 97.01% <0.00%> (-2.99%) ⬇️
container/group/group.go
internal/group/group.go 81.25% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9662ef3...369cccb. Read the comment docs.

contrib/registry/polaris/registry.go Outdated Show resolved Hide resolved
contrib/registry/polaris/registry.go Outdated Show resolved Hide resolved
contrib/registry/polaris/registry.go Outdated Show resolved Hide resolved
contrib/registry/polaris/registry.go Outdated Show resolved Hide resolved
tonybase
tonybase previously approved these changes Feb 18, 2022
Copy link
Member

@tonybase tonybase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenqidebaozi shenqidebaozi changed the title Registry for Tencent Polaris feat(registry/polaris): add registry for Tencent Polaris Feb 18, 2022
@daemon365
Copy link
Member

merge main一下 @huyuanxin

.github/workflows/go.yml Show resolved Hide resolved
contrib/registry/polaris/polaris.yaml Outdated Show resolved Hide resolved
1.add heartbeat report
2.fix conversations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants