Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix some typos #1869

Merged
merged 1 commit into from
Mar 9, 2022
Merged

fix: fix some typos #1869

merged 1 commit into from
Mar 9, 2022

Conversation

StephenChen
Copy link
Contributor

No description provided.

Copy link
Member

@daemon365 daemon365 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #1869 (bf9d8f8) into main (79057d4) will not change coverage.
The diff coverage is n/a.

❗ Current head bf9d8f8 differs from pull request most recent head 923c3d0. Consider uploading reports for the commit 923c3d0 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1869   +/-   ##
=======================================
  Coverage   80.84%   80.84%           
=======================================
  Files          80       80           
  Lines        3565     3565           
=======================================
  Hits         2882     2882           
  Misses        477      477           
  Partials      206      206           
Impacted Files Coverage Δ
errors/errors.go 96.22% <ø> (ø)
log/global.go 37.77% <ø> (ø)
log/value.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79057d4...923c3d0. Read the comment docs.

@Casper-Mars Casper-Mars self-requested a review March 9, 2022 02:45
Copy link
Contributor

@Casper-Mars Casper-Mars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@daemon365 daemon365 merged commit 4387085 into go-kratos:main Mar 9, 2022
tonybase pushed a commit that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants