Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(log): log load config only when Debug level #1899

Merged

Conversation

Cluas
Copy link
Contributor

@Cluas Cluas commented Mar 29, 2022

Description (what this PR does / why we need it):

Normally we don't need to know the config load key info, only we need to be aware of it when debugging.
So change Info level to Debug

Which issue(s) this PR fixes (resolves / be part of):

fixes #

Other special notes for reviewer:

@Cluas Cluas changed the title feat: log load config only when Debug level feat(log): log load config only when Debug level Mar 29, 2022
tonybase
tonybase previously approved these changes Mar 29, 2022
@Cluas
Copy link
Contributor Author

Cluas commented Mar 29, 2022

It looks like there is a problem with some tests, can you help look at them? @huyuanxin

@huyuanxin
Copy link
Contributor

huyuanxin commented Mar 29, 2022

It looks like there is a problem with some tests, can you help look at them? @huyuanxin

ok, I will fix docker image

update:
Now, docker image is fixed, please try run test actions again @Cluas

@Cluas
Copy link
Contributor Author

Cluas commented Mar 29, 2022

It looks like there is a problem with some tests, can you help look at them? @huyuanxin

ok, I will fix docker image

update: Now, docker image is fixed, please try run test actions again @Cluas

Thanks

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #1899 (8d8f644) into main (e66a290) will increase coverage by 0.01%.
The diff coverage is 87.50%.

❗ Current head 8d8f644 differs from pull request most recent head 69948aa. Consider uploading reports for the commit 69948aa to get more accurate results

@@            Coverage Diff             @@
##             main    #1899      +/-   ##
==========================================
+ Coverage   80.80%   80.81%   +0.01%     
==========================================
  Files          80       80              
  Lines        3568     3565       -3     
==========================================
- Hits         2883     2881       -2     
+ Misses        478      477       -1     
  Partials      207      207              
Impacted Files Coverage Δ
log/log.go 93.54% <ø> (ø)
app.go 84.15% <85.71%> (+0.50%) ⬆️
config/config.go 55.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69df1ab...69948aa. Read the comment docs.

@shenqidebaozi shenqidebaozi merged commit d4c0c57 into go-kratos:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants