New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(discovery): provide an option to disable discovery debug log #1942
Conversation
3dbd055
to
ef02909
Compare
What's this for? Do not output resolver log? |
Codecov Report
@@ Coverage Diff @@
## main #1942 +/- ##
==========================================
- Coverage 80.71% 80.66% -0.06%
==========================================
Files 81 81
Lines 3609 3615 +6
==========================================
+ Hits 2913 2916 +3
- Misses 489 492 +3
Partials 207 207
Continue to review full report at Codecov.
|
@haiyux provide an option to disable "[resolve] update instance xxx" log which is abundant and intrusive for someone and it's unstoppable now. |
How about passing a no-output logger ? I think this is more elegant. |
you can‘t even know whether the discoveryResolver started or not. |
新提供的方法DisableDebugLog()隐藏在grpc client DialInsecure()方法的内部,外部并没办法对discovery.NewBuilder()进行参数设置, 建议在 grpc client DialInsecure()的options中添加 debuglog的开关,传递至discovery.NewBuilder内部 |
Description (what this PR does / why we need it):
Issue resolved
Which issue(s) this PR fixes (resolves / be part of):
fixes #1935
Other special notes for reviewer: