fix(transport/http): responseEncoder should not write any data when it need to write nil #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t need to write nil
|
You should submit an issue and explain in the issue what problems you have encountered and why you want to solve them in this way, and then associate the PR with it to facilitate other users to understand what the PR has done |
|
@shenqidebaozi I done, is OK? |
tonybase
reviewed
Apr 26, 2022
tonybase
approved these changes
Apr 27, 2022
tonybase
pushed a commit
that referenced
this pull request
May 31, 2022
…t need to write nil (#1945) * fix(transport/http): responseEncoder should not write any data when it need to write nil * test(transport/http): adjust the test of response encoder encode nil value * fix(transport/http): remove content-type setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
It should not write any data when we don't need to return data to the client
Which issue(s) this PR fixes (resolves / be part of):
fixes #1946
Other special notes for reviewer: