Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(registry): contrib/registry/zookeeper add digest acl support #1964

Merged
merged 2 commits into from Apr 29, 2022
Merged

feat(registry): contrib/registry/zookeeper add digest acl support #1964

merged 2 commits into from Apr 29, 2022

Conversation

youzhixiaomutou
Copy link
Contributor

Description (what this PR does / why we need it):

The current registrar with zookeeper doesn't have any method for auth.
I think add a simple digest acl support is necessary.

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for reviewer:

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #1964 (cb460c2) into main (60465cc) will not change coverage.
The diff coverage is n/a.

❗ Current head cb460c2 differs from pull request most recent head 86b933b. Consider uploading reports for the commit 86b933b to get more accurate results

@@           Coverage Diff           @@
##             main    #1964   +/-   ##
=======================================
  Coverage   80.67%   80.67%           
=======================================
  Files          81       81           
  Lines        3618     3618           
=======================================
  Hits         2919     2919           
  Misses        492      492           
  Partials      207      207           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60465cc...86b933b. Read the comment docs.

Copy link
Contributor

@Cluas Cluas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonybase tonybase merged commit 9098e9d into go-kratos:main Apr 29, 2022
@Cluas
Copy link
Contributor

Cluas commented Apr 29, 2022

Thanks for the contribution!

tonybase pushed a commit that referenced this pull request May 31, 2022
)

* feat(registry): contrib/registry/zookeeper add digest acl support

* feat(registry): use WithDigestACL to put user and password together
@youzhixiaomutou youzhixiaomutou deleted the feat/registry_zookeeper_digest_acl branch July 21, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants